Add docs for artax-adapter #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Jul 13, 2017
clients/artax-adapter.rst
Outdated
| use Http\Adapter\Artax\Client as ArtaxAdapter; | ||
| use Http\Message\MessageFactory\GuzzleMessageFactory; | ||
|
|
||
| $adapter = new BuzzAdapter(new DefaultClient(), new GuzzleMessageFactory()); |
There was a problem hiding this comment.
I knew I forgot something.
Nyholm
approved these changes
Jul 13, 2017
|
Seams like you have to add "Artax" to the spelling docs. Im happy when Travis is happy. |
|
Where do I add that? |
|
Here: https://github.com/php-http/documentation/blob/master/spelling_word_list.txt There is a dictionary which we spell check words against. The word "Artax" is not in that dictionary. So we need to add it to the spelling_word_list.txt to say that it is correctly spelled. |
|
Travis is fine. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #205